Add support for Sudo. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us detect the need for sudo.
This will be set to true if the statement needs to be operated under the use of sudo.
With this commit the `Run` and `IfChanged` tokens will honour
the sudo-flag, if the appropriate token is seen.
For example this is "normal":
Run "/usr/bin/id"
But this will run as root:
Sudo Run "/usr/bin/id"
(Of course we need support in the evaluator before this actually
works; this is just the setup.)
We scan the statements to be executed before we run them, and prompt for a sudo-password if the use of Sudo is in-place. We then execute our command(s) with sudo as appropriate. This makes our code functional. TODO: * More tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request is work-in-progress, but currently allows the use of the
Sudotoken to mark a following statement as requiring the use ofsudo.For example this is a normal script:
Expected output will be "user ..".
This would require the use of Sudo:
Expected output will be "root .."
This will close #8, when merged.