Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make path an optional input variable in forecast_plot.plot_forecast() #68

Closed
bezes opened this issue Oct 15, 2018 · 0 comments · Fixed by #71
Closed

Make path an optional input variable in forecast_plot.plot_forecast() #68

bezes opened this issue Oct 15, 2018 · 0 comments · Fixed by #71
Labels
good first issue Good for newcomers

Comments

@bezes
Copy link
Contributor

bezes commented Oct 15, 2018

When using output='jupyter', no path is needed.
When output='png' or output='html' we need to verify path is not empty.
@bezes bezes added the good first issue Good for newcomers label Oct 15, 2018
slenas added a commit that referenced this issue Oct 15, 2018
@slenas
Make path an optional input variable in plot_forecast() #68
8a42d95
slenas added a commit that referenced this issue Oct 15, 2018
@slenas
Fix tutorial to reflect changes in plot_forecast() #68
bfafcad
@slenas slenas mentioned this issue Oct 15, 2018
Merged
slenas added a commit that referenced this issue Oct 16, 2018
@slenas
Addressing code review comments #68
2782ecd
slenas added a commit that referenced this issue Oct 16, 2018
@slenas
Fix bug with respect to the case where path is empty and not None. Ad…
9941518 
…d relevant tests. #68
slenas added a commit that referenced this issue Oct 16, 2018
@slenas
Use return 0 to indicate successful execution and return 1 for the op…
0475258 
…posite. #68
@bezes bezes closed this as completed in #71 Oct 16, 2018
bezes pushed a commit that referenced this issue Oct 16, 2018
@slenas @bezes
68 path optional plot forecast (#71)
2856f6b 
* Make path an optional input variable in plot_forecast() #68

* Fix tutorial to reflect changes in plot_forecast() #68

* Addressing code review comments #68

* Fix bug with respect to the case where path is empty and not None. Add relevant tests. #68

* Use return 0 to indicate successful execution and return 1 for the opposite. #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

68 path optional plot forecast sky-uk/anticipy
1 participant
@bezes