Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore postmortem debugging #170

Merged
merged 2 commits into from Dec 1, 2020
Merged

Restore postmortem debugging #170

merged 2 commits into from Dec 1, 2020

Conversation

aecay
Copy link
Collaborator

@aecay aecay commented Dec 1, 2020

It turns out that there are differences between set_trace and
post_mortem debugger calls. Unfortunately PEP553 doesnʼt support
customizing the latter, so we have to DIY.

It turns out that there are differences between set_trace and
post_mortem debugger calls.  Unfortunately PEP553 doesnʼt support
customizing the latter, so we have to DIY.
Copy link
Contributor

@paulpepper-sky paulpepper-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With side-channel explanation from Aaron, makes sense to default to using pdb.post_mortem() as a way to enter the debugger at the stack frame from the exception, rather than at the point where the breakpoint() is called.

@aecay aecay merged commit b8d463f into master Dec 1, 2020
@aecay aecay deleted the postmortem-debug branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants