Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 19 - adding additional csv content types #27

Closed
wants to merge 1 commit into from

Conversation

jawood1
Copy link
Contributor

@jawood1 jawood1 commented Dec 7, 2023

@abjerner initial pull request for #19

This has been seperated out from original pull request #22

I know you said this needs additional investigation any help I can provide let me know :)

Once again I've included for the content types initially:

  • application/vnd.ms-excel
  • text/csv

abjerner added a commit that referenced this pull request Jan 6, 2024
@abjerner abjerner added type/bug Something isn't working community/pr labels Jan 6, 2024
@abjerner
Copy link
Member

abjerner commented Jan 6, 2024

Hi @jawood1

As discussed in #19 the list allowed content types is probably something that should be configurable. The solution for this is therefore a bit different, which is why I've closed this PR.

When reading some of the links you have provider, I'd still say that the problem is caused by incorrect file associations on the user system. But I don't really have any overview of how often users will have an incorrect file association. So the default configuration allows the following content types:

text/plain
text/x-csv
application/vnd.ms-excel
application/csv
application/x-csv
text/csv
text/comma-separated-values
text/x-comma-separated-values
text/tab-separated-values

I was a bit hesitant to allow too many content type, but the code also checks that the file extension is .csv, so the combination of the content types listed above and the .csv extension should be fine.

Thanks for your feedback and helping with discussing the issue 👍

@abjerner abjerner closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants