Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node FIXED & Updated (and install.sh corrected) #173

Merged
merged 29 commits into from
Jun 26, 2016

Conversation

thedamian
Copy link
Contributor

@thedamian thedamian commented May 27, 2016

Fixes issue: #155 and #143 and #138

Node is Fixed (sorry for the delay, ready below as to why it took so long if interested)
ALSO the install.sh ln of the gcc to cc (to fix some of the errors out there)

-- What too so long --
I went to the dark side (first moved to crew and then full ubuntu on my chromebook pixel)

But I'm back... and I noticed NODE and NODE_STABLE wasn't installing and my install.sh contribution to make some app builds work wasn't in sudo (which was needed)

the node fix came from stealing of the LinuxBrew formula.
(Always thank the giants who's shoulders you stand on while urinating really far)

ALSO changed the name of "NODE_STABLE" to "NODE_CURRENT" to follow the naming convention of node (NODE!: Stop changing how you name everything!)

@thedamian
Copy link
Contributor Author

to use these files yourself (to test or to fix the issues) simply copy the *.rb files to /usr/local/crew/packages/ and you'll be able to do a

crew install node_current

and you'll have node with NPM installed. (Now a days with that you can almost do ANYTHING!)

@thedamian
Copy link
Contributor Author

Mono package added. .Net is coming people!
And the permissions to make a lot of packages easier to install

@thedamian thedamian mentioned this pull request Jun 2, 2016
source_url ({
i686: "https://www.dropbox.com/s/d1omw087ilkh5oq/jdk1.8.0_25_i686.tar.gz?dl=0",
x86_64: "https://www.dropbox.com/s/ykw2jt797cpghfy/jdk1.8.0_65_x86_64.tar.gz?dl=0"
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thedamian I'm always trying not to complain about indentation, but this is so visible 😀

@skycocker
Copy link
Member

@thedamian what about users who already have node_stable installed?

@thedamian
Copy link
Contributor Author

thedamian commented Jun 22, 2016

If you're still there. It's fixed.

  1. Dart wasn't ready, so it's removed.
  2. Node has changed their naming from "stable" to "current" so I feel we should change the name of the package. Both are there now and both are up to date.

thedamian and others added 5 commits June 22, 2016 19:37
Recently formattet my chromebook pixel and wanted to try everyone's change of install.sh so I've merged pull chromebrew#176 into mine to try it.
Reverting back the changes I was trying for pull 178 in the master repo
I'm bad with my reverts because I'm reverting through github since I'm on my virgin chromebook
@thedamian
Copy link
Contributor Author

Just did a powerwash of my chromebook. Went to regular user and back to developer mode (still in stable channel) and then ran MY install.sh with success and installed NODE from my version of the projects.

everything is looking good.

I tried pull 178 (the removing of the sudo) but it didn't work. nothing got created and nothing was running (hence why I had to do a powerwash)

@skycocker
Copy link
Member

Looks like it's fine then. Thanks for all the work!

@skycocker skycocker merged commit 37eb9ae into chromebrew:master Jun 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants