Show the number of coins going in or out in a tx (address page) #74
Conversation
src/app/app.datatypes.ts
Outdated
| export function parseGetAddressTransaction(raw: GetAddressResponseTransaction, address: string): Transaction { | ||
|
|
||
| //Detect if the address sent or received the coins. | ||
| let incoming: boolean = true; |
There was a problem hiding this comment.
You don't have to type-cast it as a boolean, typescript will auto typecast as the default value is true
src/app/app.datatypes.ts
Outdated
|
|
||
| //Detect if the address sent or received the coins. | ||
| let incoming: boolean = true; | ||
| if (raw.inputs[0].owner.toLowerCase() == address.toLowerCase()) { incoming = false; } |
There was a problem hiding this comment.
Same line if statement does not require brackets
src/app/app.datatypes.ts
Outdated
| if (raw.inputs[0].owner.toLowerCase() == address.toLowerCase()) { incoming = false; } | ||
|
|
||
| //Calculate the amount of incoming or outgoing coins, as appropriate. | ||
| let coins:number = 0; |
There was a problem hiding this comment.
coins does not need to be cast as a number, will automatically be cast due to default value being a number
src/app/app.datatypes.ts
Outdated
| //Calculate the amount of incoming or outgoing coins, as appropriate. | ||
| let coins:number = 0; | ||
| for (let output of raw.outputs) { | ||
| if ((incoming == true) && (output.dst.toLowerCase() == address.toLowerCase())) { |
There was a problem hiding this comment.
- Don't need to compare with true as incoming is already a boolean
- Brackets are redundant
src/app/app.datatypes.ts
Outdated
| @@ -131,6 +150,7 @@ function parseGetBlocksTransaction(transaction: GetBlocksResponseBlockBodyTransa | |||
| inputs: transaction.inputs.map(input => ({ address: null, coins: null, hash: input, hours: null })), | |||
| outputs: transaction.outputs.map(output => parseGetBlocksOutput(output)), | |||
| status: null, | |||
| coins_change: 0, | |||
There was a problem hiding this comment.
When adding default values to be calculated always use null instead of 0
| @@ -41,5 +41,6 @@ <h2>{{ address }}</h2> | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <div class="row -row"><div attr.class="{{'coins_change_box '+(transaction.coins_change < 0 ? '-red' : '-green')}}">{{ (transaction.coins_change<0?"":"+")+transaction.coins_change.toString() }}</div></div> | |||
src/app/app.datatypes.ts
Outdated
| @@ -41,6 +41,7 @@ export class Transaction { | |||
| outputs: Output[]; | |||
| status: boolean; | |||
| timestamp: number; | |||
| coins_change: number; | |||
There was a problem hiding this comment.
Can we use balance or value instead of coins_change, I feel like this is more in line with the language used so far
src/app/app.datatypes.ts
Outdated
|
|
||
| //Detect if the address sent or received the coins. | ||
| let incoming: boolean = true; | ||
| if (raw.inputs[0].owner.toLowerCase() == address.toLowerCase()) { incoming = false; } |
There was a problem hiding this comment.
You have to check for each input, as the input could also be a second or later element in the array
|
Hello, thank you very much for the comments, I had doubts about the style I should use and now I understand better how to style the code. Additionally, I tried to make all the changes, but there was a problem: at first I assumed wrongly that all the inputs of the transactions come from the same address but in reality the inputs could come from multiple addresses. Because of that and the fact that the api only indicates the id and owner of each input (without indicating the amount of coins) it is only possible to know how many coins entered or left the account in each transaction by making a call to /api/uxout for each input of every transaction, which could have a very negative effect on performance. Because of that, I eliminated the sum of incoming-outgoing coins and simply placed a box that indicates whether coins entered or exited during the transaction. It is not as good as the amount of coins, but at least it helps to better understand the content of the screen. Here is a screenshot of how the new box looks like: |
|
@Senyoret1 can you describe what API data would be necessary to display in/out flows? |
|
Greatly improved, thanks! Please create an issue for the required API change |
Now the address screen shows the amount of coins that went in or out the address in each transaction. I think the green color shown when coins go into the address is very clear, but it is the one established in the Brand Guidelines. The amount of coins shows only up to 6 decimals. Issue involved: skycoin/skycoin#754
