-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoder optimizations #1915
Merged
Merged
Encoder optimizations #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olemis
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (some of) #1878
Changes:
dchk
in Deserialize methods with error handling during deserializationParseTag
method to remove memory allocations (strings.Split
)Does this change need to mentioned in CHANGELOG.md?
No
There are probably some more optimizations in here, the biggest ones might require caching which has its own issues. At the very least, the results of reflecting the struct for
datasizeWrite
could be shared withencoder.value
. Also, determining the buffer length for slices of structs could be optimized if we can detect that the struct is composed of entirely fixed size objects (no strings, no slices).It might be that the cost of datasizeWrite is higher than the cost of using a buffer that grows as needed. This is probably true, except maybe for the simplest structs.
Better gains will be had from replacing reflection with code generation.
Benchmark results: