Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior when manipulating app args #660

Closed
jdknives opened this issue Jan 21, 2021 · 0 comments
Closed

Inconsistent behavior when manipulating app args #660

jdknives opened this issue Jan 21, 2021 · 0 comments
Assignees
Labels
bug Something isn't working urgent This issue should be done with the highest priority

Comments

@jdknives
Copy link
Member

jdknives commented Jan 21, 2021

Describe the bug

When setting the secure mode for the VPN-server via HypervisorUI and without setting a password, the hypervisor UI adds these values

		"name": "vpn-server",
				"args": [
					"-passcode",
					"",
					"-secure",
					"true"
				],

This leads to the VPN-server not registering itself in the service discovery because the check we perform is not sufficient. This needs to be fixed.

When unchecking the box of secure mode again, this is the updated config value:

	"name": "vpn-server",
				"args": [
					"-secure",
					"false"
				],

This is probably not the best way to deal with it. Imo, it sounds cleaner to generate the default values at config generation and always update all of the values when manipulating at least one of them via the hypervisor. The check for whether the VPN is password protected needs to be improved to actually check whether the password is non-empty instead of just checking if the arg is present.

@jdknives jdknives added the bug Something isn't working label Jan 21, 2021
@jdknives jdknives added the urgent This issue should be done with the highest priority label Jan 21, 2021
@jdknives jdknives added this to To do in Skywire v0.4.0 Jan 21, 2021
@jdknives jdknives moved this from To do to Done in Skywire v0.4.0 Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working urgent This issue should be done with the highest priority
Projects
No open projects
Development

No branches or pull requests

2 participants