Fix/check empty password #663

jdknives · 2021-01-22T18:54:22Z

Did you run make format && make check?

Yes

Fixes #660 at least the bug. The inconsistency remains.

Changes:

adds check to verify if password is empty. If password is empty, the appupdater is being created. Previously empty string password would lead to appdiscupdater not being created which is not the correct behavior.

How to test this PR:

run VPN-server with passcode arg set to empty string against prod deployment
verify the VPN server gets registered here: https://service.discovery.skycoin.com/api/services?type=vpn

Darkren

Great job! But I'm afraid it may panic. Not sure though

pkg/app/appdisc/factory.go

i-hate-nicknames

Great job! I would move argVal function to pkg/app/appcommon/proc_config.go, since it's a generic arg operation

jdknives · 2021-01-26T14:19:58Z

Great job! I would move argVal function to pkg/app/appcommon/proc_config.go, since it's a generic arg operation

Probably a good idea. will do that.

jdknives requested a review from i-hate-nicknames January 22, 2021 18:54

add empty pw check to auppupdater factory

914c59e

Darkren suggested changes Jan 25, 2021

View reviewed changes

pkg/app/appdisc/factory.go Outdated Show resolved Hide resolved

add condition to check for appupdate pw vpn-server

0cd5228

i-hate-nicknames reviewed Jan 26, 2021

View reviewed changes

jdknives added 2 commits January 26, 2021 11:21

refactor procArgs functions into appcommon

11d3260

comment on functions to fix linter

e6eb6dc

Darkren approved these changes Jan 27, 2021

View reviewed changes

jdknives merged commit e398e87 into skycoin:develop Jan 27, 2021

Provide feedback