Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable test case #865

Closed
mrpalide opened this issue Aug 25, 2021 · 2 comments
Closed

Unstable test case #865

mrpalide opened this issue Aug 25, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mrpalide
Copy link
Contributor

Describe the bug
The Uptime test case on /pkg/visor/rpc_test.go has unstable behavior on AppVeyor MacOS image, sometimes passed and sometimes failed.
These are my last three tests, the oldest PASSED, next one FAILED and the latest PASSED again!
This problem just happened in MacOS image and everything is OK on Linux image.
@mrpalide mrpalide added the bug Something isn't working label Aug 25, 2021
@mrpalide mrpalide changed the title Unstable testcase Unstable test case Aug 25, 2021
@alexadhy
Copy link
Contributor

The cause is probably slight delay while testing for uptime, probably we should change the test case itself, rather than matching it against string , we could compare uptime against minimum expected uptime (say 1 second) for example.

@mrpalide
Copy link
Contributor Author

mrpalide commented Sep 7, 2021

Fixed in #854

@mrpalide mrpalide closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexadhy @mrpalide