fix(visor.summary): data race condition #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a waitgroup (producer-consumer) and force the summary to await until NewVisor finish. fix skycoin#998
ersonp
approved these changes
Nov 15, 2021
mrpalide
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? Yes, themake checkaccused 4 errors (G307,time-naming) in the files:pkg/util/rename/rename.go,pkg/transport/network/stcp/pktable.go,pkg/restart/restart_test.go). However, since the code is already using this workaround, I didn't change it.Fixes #998
Changes:
Visorstruct to force the(*Visor).Summaryawait untilNewVisorfinish.How to test this PR: