Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic #1028

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Fix panic #1028

merged 1 commit into from
Dec 15, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Dec 15, 2021

This commit fixes the panic by checking if the stunClient is initilised or not before checking the NATType.

Did you run make format && make check?
yes

Fixes #1027

Changes:

  • Added check to see if stunClient is not nil

How to test this PR:

  1. On in config with test deployment set the vpn-client as
    {
    	"name": "vpn-client",
    	"args": [
    		"-srv",
    		"03e6a435b16de6ac49d78dea29e5f136c1b223a2b7128d61c36f29eef343040ad2"
    	],
    	"auto_start": true,
    	"port": 43
    },
  2. Run sudo ./skywire-visor -c skywire-visor.json
  3. Check if there is no panic

This commit fixes the panic by checking if the stunClient is initilised or not before checking the NATType.
@jdknives jdknives merged commit b6ca868 into skycoin:develop Dec 15, 2021
@ersonp ersonp deleted the fix/vpn-nilpointer branch April 11, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants