Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport master fix to milestone2 #106

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Backport master fix to milestone2 #106

merged 2 commits into from
Jan 6, 2020

Conversation

Kifen
Copy link
Contributor

@Kifen Kifen commented Jan 6, 2020 •
edited by nkryuchkov

Fixes #84

Changes:

  • Change app config values from slice to map

How to test this PR:

  • `make test`

nkryuchkov
nkryuchkov approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great job!

@jdknives jdknives merged commit 4ede499 into skycoin:milestone2 Jan 6, 2020
@Kifen Kifen deleted the backport-appconfig branch January 6, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kifen @nkryuchkov @jdknives