Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for the VPN UI status #1235

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Improvements for the VPN UI status #1235

merged 2 commits into from
Jun 17, 2022

Conversation

Senyoret1
Copy link
Contributor

Did you run make format && make check?
The go code was not changed. npm run lint and npm run build were used.

Fixes #1229

Changes:

  • Now the status of the VPN UI is updated just after the API call returns.

How to test this PR:
Follow the steps in the issue. The status should show connecting from the start.

@mrpalide
Copy link
Contributor

In first attempt everything is OK, but in next, the disconnected status appears yet. See this:

cast.mov

@Senyoret1
Copy link
Contributor Author

@mrpalide Thanks for noticing the problem. Should be fixed now.

@mrpalide mrpalide merged commit bfdc2f0 into skycoin:develop Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrpalide mrpalide mrpalide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Senyoret1 @mrpalide