Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve skywire-cli ut command logic #1679

Merged
merged 3 commits into from
Dec 9, 2023
Merged

improve skywire-cli ut command logic #1679

merged 3 commits into from
Dec 9, 2023

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Nov 23, 2023 •
edited

Did you run make format && make check? Yes

Fixes #1634

Changes:

  • add new endpoint to utClient for fetching data from UT by visor, in dmsghttp and simple http query
  • change the logic if fetching UT data in skywire-cli ut command and make order as:
    • visor (dmsghttp or http, based on its config)
    • dmsghttp (no related to visor) [will work on it later, in other PR]
    • http (no related to visor)

How to test this PR:

  • build
  • run visor on both config, run skywire-cli ut -os for get count of online visors
  • stop visor and run skywire-cli ut -os comment again

@mrpalide mrpalide changed the title improve skywire-cli ut command logic [WIP] improve skywire-cli ut command logic Nov 23, 2023
@mrpalide mrpalide changed the title [WIP] improve skywire-cli ut command logic improve skywire-cli ut command logic Nov 23, 2023
@mrpalide mrpalide marked this pull request as ready for review November 23, 2023 14:05
@0pcom 0pcom mentioned this pull request Nov 24, 2023
Open
@0pcom 0pcom self-requested a review December 9, 2023 15:34
0pcom
0pcom approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@0pcom 0pcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@0pcom 0pcom merged commit 5dc0aba into skycoin:develop Dec 9, 2023
3 checks passed
@mrpalide mrpalide deleted the feat/improve-skywire-cli-ut-command-logic branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0pcom 0pcom 0pcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrpalide @0pcom