Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skywire-cli config gen --all #1735

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented Feb 9, 2024

the full help menu did not exit as it should have; and instead it printed the full help, returned from the prerun and then proceeded with run instead of exiting completely.

@0pcom
Copy link
Collaborator Author

0pcom commented Feb 9, 2024

there were more logical issues with the order of operations. These have been resolved such that, in the absence of services-config.json and internet connection, the hardcoded servers in skywire-utilities/pkg/skyenv are used

here is the failure mode
image

@0pcom 0pcom merged commit 945f786 into skycoin:develop Feb 9, 2024
3 checks passed
@0pcom 0pcom deleted the fix-configgen branch March 7, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant