Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to united binary #1776

Merged

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Mar 18, 2024

Did you run make format && make check? Yes

Fixes #1769

Changes:

  • use merged binary in windows and mac
  • update goreleaser and installers scripts

How to test this PR:

  • use make build-merged or build-merged-windows based on you os
  • in /build folder, trying to generate config by skywire cli config gen or skywire.exe cli config gen
  • check configs in launcher apps part
  • run visor by skywire visor -c skywire-config.json or with .exe extension on Windows
  • everything should work as well as
  • copy old config there, regenerate by -r flag and check apps part again

Note: release and installer will test after merging this PR

@jdknives jdknives closed this Mar 18, 2024
@0pcom 0pcom reopened this Mar 19, 2024
@0pcom
Copy link
Collaborator

0pcom commented Mar 19, 2024

stream closed error is I believe an error on prod, all the tests passed before the PR was closed. No changes have been made since them. Merging.

image

@0pcom 0pcom merged commit e13ffd2 into skycoin:develop Mar 19, 2024
6 of 7 checks passed
@0pcom 0pcom changed the title Move to merged binary Move to united binary Mar 19, 2024
@mrpalide mrpalide deleted the feat/skywire-deployment-for-windows-and-mac branch March 26, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants