Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app launch #1778

Merged
merged 10 commits into from
Mar 19, 2024
Merged

Fix app launch #1778

merged 10 commits into from
Mar 19, 2024

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented Mar 19, 2024

The bin path set in the config was not being obbserved by the visor when launching apps, causing the following error

[2024-03-19T15:11:32.994167031-05:00] WARN AutoStart [launcher]: Failed to start app. app_name="skychat" args=[app skychat --addr :8001] envs=[] error="fork/exec /home/user/go/src/github.com/skycoin/skywire: permission denied"
[2024-03-19T15:11:32.996215014-05:00] WARN AutoStart [launcher]: Failed to start app. app_name="skysocks" args=[app skysocks] envs=[] error="fork/exec /home/user/go/src/github.com/skycoin/skywire: permission denied"

This was addressed, and the Makefile was updated to only build the unified / united binary

@0pcom
Copy link
Collaborator Author

0pcom commented Mar 19, 2024

[2024-03-19T15:41:48.869314101-05:00] INFO [proc:skychat:ae8dccb462e14cf48bf72bff258fa8b6]: App skychat is Running
[2024-03-19T15:41:48.870620843-05:00] INFO [proc:skysocks:7b86c536efd84941aec31178a10eb8f0]: App skysocks is Running

tested, working.

@0pcom 0pcom merged commit 11dfbbb into skycoin:develop Mar 19, 2024
3 checks passed
@0pcom 0pcom deleted the fix-applaunch branch March 19, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant