Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skywire cli visor route subcommand implementation #1798

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

0pcom
Copy link
Collaborator

@0pcom 0pcom commented Apr 1, 2024

  • removed parsing positional arguments - parsing flags only
  • simplify initialization
  • shorten subcommand names
  • combine skywire cli visor route rule and skywire cli visor route ls-rules subcommands into skywire cli visor route

image

image

image

image

image

image

image

image

@0pcom
Copy link
Collaborator Author

0pcom commented Apr 1, 2024

The previous commit moves skywire cli visor route to skywire cli route and skywire cli visor tp to skywire cli tp

similar changes were made in combining subcommand functionality to the parent command and removing extra subcommands.

image

image

image

image

image

image

image

@0pcom 0pcom merged commit 9052899 into skycoin:develop Apr 1, 2024
3 checks passed
@0pcom 0pcom deleted the fix-cli-visor-route branch April 1, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant