Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update endpoint. #214

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Fix update endpoint. #214

merged 5 commits into from
Mar 9, 2020

Conversation

evanlinjin
Copy link
Contributor

@evanlinjin evanlinjin commented Mar 9, 2020 •
edited

Fixes #213

Changes:

  • Added defer statement to Updater.Update to revert u.updating value back to 0 after updating.
  • Make restart.Context reset it's internal exec.Cmd on failure.
  • Changed restart visor endpoint to only accept POST.
  • Update restart.Restart test.

Fix #213
5a0d224 
* Added defer statement to Updater.Update to revert u.updating value back to 0 after updating.
jdknives
jdknives approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot reproduce the error anymore.

nkryuchkov
nkryuchkov approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@nkryuchkov nkryuchkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

pkg/restart/restart.go Outdated Show resolved Hide resolved
@jdknives jdknives merged commit c49c613 into skycoin:milestone2 Mar 9, 2020
@Senyoret1 Senyoret1 mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov approved these changes

@jdknives jdknives jdknives approved these changes

@Darkren Darkren Awaiting requested review from Darkren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot update call update endpoint twice.
3 participants
@evanlinjin @nkryuchkov @jdknives