Integrate manager UI with the hypervisor #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkren
changed the title
Darkren
requested review from
nkryuchkov and
evanlinjin
and removed request for
nkryuchkov
jdknives
approved these changes
Mar 22, 2020
There was a problem hiding this comment.
Well done. Works smoothly. The only issue we need to discuss is the authentication with @evanlinjin
evanlinjin
approved these changes
Mar 23, 2020
…nto feature/simplify-manager-ui-build-process
… regardless of `enable_auth` value
This was referenced Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Yes
Fixes #224
Changes:
enable_authif nowfalseby defaulthttp_addris now:8080by defaultweb_dirfield is added to hypervisor's config. This directory contains built frontendHow to test this PR:
hypervisor gen-config -thypervisor -c hypervisor-config.jsonhttp:///localhost:8080