Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement callbacks needed for VPN client #526

Merged
merged 3 commits into from
Sep 28, 2020
Merged

Implement callbacks needed for VPN client #526

merged 3 commits into from
Sep 28, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Sep 17, 2020

Did you run make format && make check?
Yes
Fixes #383

Changes:

  • Now transport manager has method OnTPCloseCallback which sets callback firing on transport close. This callback gets propagated to all already established and newly created transports;
  • Transports execute this callback after they get closed;
  • VPN client makes use of these callbacks to remove direct routes.

nkryuchkov
nkryuchkov reviewed Sep 21, 2020
View reviewed changes
internal/vpn/client.go Outdated Show resolved Hide resolved
pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
pkg/transport/manager_test.go Outdated Show resolved Hide resolved
@jdknives jdknives merged commit cd93eb5 into skycoin:feature/v0.4.0 Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Darkren @nkryuchkov @jdknives