Make the manager work with the integrated hypervisor #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdknives
reviewed
Oct 27, 2020
| "state": "State", | ||
| "state-tooltip": "Current state", | ||
| "label": "Label", | ||
| "key": "Key", | ||
| "dmsg-server": "DMSG server", | ||
| "ping": "Ping", | ||
| "hypervisor-info": "The visor contains the currently used Hypervisor.", |
There was a problem hiding this comment.
This visor is the current Hypervisor. sounds better. Other than that good job.
|
@jdknives The last commit updates the tooltip text. |
jdknives
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?The go code was not changed.
npm run lintandnpm run buildwere used.Fixes #562 (to some extend).
Changes:
How to test this PR:
Open the Skywire manager. The visor list now has a column at the left which contains a star if the visor is the current hypervisor. Also, the option for updating the Hypervisor is no longer present in the options menu of the visor list.