Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac installer #889

Merged
merged 57 commits into from
Oct 18, 2021
Merged

Mac installer #889

merged 57 commits into from
Oct 18, 2021

Conversation

alexadhy
Copy link
Contributor

@alexadhy alexadhy commented Sep 23, 2021

Did you run make format && make check? yes

For Skywire-Visor Release 0.5.0-rc*

Changes:

  • Package skywire-visor as macos application

TODO:

  • Fix application not installed correctly
  • Fix updating application
  • Fix application icon (not systray icon) not showing properly on /Applications
  • Also builds arm64 binaries

To Test:

@alexadhy
Copy link
Contributor Author

alexadhy commented Sep 23, 2021

Instruction to run it:

record.mp4
  • Then Install it, It should ask for your password to run it (or your fingerprint)
  • To run vpn-client, do:
$ skywire-cli visor add-tp <YOUR_VPN_SERVER_PK> --type dmsg
$ skywire-cli visor start-app vpn-client

or via UI

Click VPN link menu, it should show:

systray.mp4

To create mac-installer with codesign, you need to:

  1. Have valid Apple Developer Account
  2. Export these environment variables:
 $ MAC_HASH_APPLICATION_ID="???"    #  Hash for Certificate for Application ID
 $ MAC_HASH_INSTALLER_ID="???" # Hash for Certificate Installer ID
 $ MAC_DEVELOPER_USERNAME="???"              # Apple Developer account email
 $ MAC_DEVELOPER_PASSWORD="???"             # Apple Developer account password
  1. Run
$ ./scripts/mac_installer/create-installer.sh -s -n

@alexadhy
Copy link
Contributor Author

App Icon should be working just fine now:

Screen Shot 2021-09-23 at 22 12 14

@alexadhy
Copy link
Contributor Author

Last few commits fixes privileges on macos installer and application runner

Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sent the error log of the installation on Element.

Two more points:

  1. Is it possible to make Apple use the version we embed in the binary or do we have to set that somewhere dfiferently.
  2. There is an option to set a readme for the installer. What is that used for or how would the user pull that up on Apple?

scripts/mac_installer/create_installer.sh Show resolved Hide resolved
@alexadhy
Copy link
Contributor Author

I have sent the error log of the installation on Element.

Two more points:

  1. Is it possible to make Apple use the version we embed in the binary or do we have to set that somewhere dfiferently.

We can, I'll dynamically generate it / add it to the Info.plist

  1. There is an option to set a readme for the installer. What is that used for or how would the user pull that up on Apple?

We can via rtf files converted to b64 image iIrc, will investigate and do it if needed.

cmd/skywire-visor/commands/root.go Outdated Show resolved Hide resolved
Makefile Outdated
@@ -174,5 +171,11 @@ build-ui: install-deps-ui ## Builds the UI
mkdir ${MANAGER_UI_BUILT_DIR}
cp -r ${MANAGER_UI_DIR}/dist/. ${MANAGER_UI_BUILT_DIR}

mac-installer: ## Create unsigned application
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make this create a signed installer and application. Otherwise there is not much of a point to the target as we will likely only release signed installers.

cmd/skywire-cli/commands/config/gen.go Outdated Show resolved Hide resolved
internal/gui/gui.go Show resolved Hide resolved
internal/gui/gui.go Outdated Show resolved Hide resolved
scripts/mac_installer/create_installer.sh Show resolved Hide resolved
@jdknives jdknives merged commit a80edc4 into skycoin:develop Oct 18, 2021
@alexadhy alexadhy deleted the mac-installer branch November 23, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants