-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac installer #889
Mac installer #889
Conversation
Instruction to run it: record.mp4
$ skywire-cli visor add-tp <YOUR_VPN_SERVER_PK> --type dmsg
$ skywire-cli visor start-app vpn-client or via UI Click VPN link menu, it should show: systray.mp4To create mac-installer with codesign, you need to:
$ MAC_HASH_APPLICATION_ID="???" # Hash for Certificate for Application ID
$ MAC_HASH_INSTALLER_ID="???" # Hash for Certificate Installer ID
$ MAC_DEVELOPER_USERNAME="???" # Apple Developer account email
$ MAC_DEVELOPER_PASSWORD="???" # Apple Developer account password
$ ./scripts/mac_installer/create-installer.sh -s -n |
Last few commits fixes privileges on macos installer and application runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have sent the error log of the installation on Element.
Two more points:
- Is it possible to make Apple use the version we embed in the binary or do we have to set that somewhere dfiferently.
- There is an option to set a readme for the installer. What is that used for or how would the user pull that up on Apple?
We can, I'll dynamically generate it / add it to the Info.plist
We can via rtf files converted to b64 image iIrc, will investigate and do it if needed. |
dcd98db
to
26fd253
Compare
…or output to file
Makefile
Outdated
@@ -174,5 +171,11 @@ build-ui: install-deps-ui ## Builds the UI | |||
mkdir ${MANAGER_UI_BUILT_DIR} | |||
cp -r ${MANAGER_UI_DIR}/dist/. ${MANAGER_UI_BUILT_DIR} | |||
|
|||
mac-installer: ## Create unsigned application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make this create a signed installer and application. Otherwise there is not much of a point to the target as we will likely only release signed installers.
Did you run
make format && make check
? yesFor Skywire-Visor Release 0.5.0-rc*
Changes:
TODO:
/Applications
To Test:
make mac-installer
and run the installer viaopen ./SkywireInstaller.pkg
or see Mac installer #889 (comment)