Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Autoconnect [API | Summary] #915

Merged
merged 6 commits into from
Oct 12, 2021
Merged

Public Autoconnect [API | Summary] #915

merged 6 commits into from
Oct 12, 2021

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Oct 7, 2021

Did you run make format && make check? Yes

Fixes #904

Changes:

  • Add public_autoconnect field to /visors/{pk}/summary endpoint
  • Make new endpoint PUT /visors/{pk}/public-autoconnect to change value of public_autoconnect. The body of request should be same as {"public_autoconnect":true}.

How to test this PR:

  • Check summary on network monitor to see public_autoconnect field.
  • Make PUT request on /visors/{pk}/public-autoconnect endpoint with {"public_autoconnect":true} or {"public_autoconnect":false} to change its value.
  • Check summary again for changes.

Note:
As I talked to @jdknives , after this changes we need restart/reboot visor to start connector routine. Maybe after successful change, we should show some alert/notification to user for reboot visor. @Senyoret1

pkg/visor/hypervisor.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexadhy alexadhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the functionality is working good.

@jdknives jdknives merged commit bb755a4 into skycoin:develop Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants