Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: initial support for podman #1520

Merged
merged 9 commits into from Mar 20, 2019
Merged

ansible: initial support for podman #1520

merged 9 commits into from Mar 20, 2019

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Dec 11, 2018

Background:
libpod aka Podman is library for running OCI-based containers in Pods.
It is likely going to replace Docker in newer versions of RHEL systems,
which means Docker won't be supported in the future.

The CLI is supposed to work like it did with Docker (with some changes);
so this patch is pretty basic. It adds skydive_container_cli variable
(default to docker for backward compatibiility) and replace the
hardcoded "docker" commands by using this variable instead.

Some adjustments were made:

  • podman doesn't need docker socket access.
  • podman doesn't support --restart natively, we need a systemd service.
  • podman doesn't require to have docker started.

Future iterations will be made to support proper SystemD/Podman
integration like it was done in TripleO for other containers:
http://my1.fr/blog/openstack-containerization-with-podman-part-2-operations/

Closes #1517
Signed-off-by: Emilien Macchi emilien@redhat.com

skip skydive-go-fmt
skip skydive-functional-tests-backend-elasticsearch
skip skydive-functional-tests-backend-orientdb
skip skydive-scale-tests
skip skydive-cdd-overview-tests
skip skydive-unit-tests
skip skydive-compile-tests
skip skydive-k8s-tests
skip skydive-ppc64le-tests
skip skydive-functional-hw-tests

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

22 similar comments
@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@skydive-bot
Copy link
Member

Can one of the admin review this patch ?

@safchain
Copy link
Collaborator

ok to test

@safchain
Copy link
Collaborator

@EmilienM I just invited you, once you accepted (please do :) we will be able to trigger CI job

@lebauce
Copy link
Member

lebauce commented Dec 11, 2018

run skydive-vagrant-tests

2 similar comments
@lebauce
Copy link
Member

lebauce commented Dec 11, 2018

run skydive-vagrant-tests

@EmilienM
Copy link
Contributor Author

run skydive-vagrant-tests

@lebauce
Copy link
Member

lebauce commented Dec 12, 2018

run vagrant-tests

1 similar comment
@lebauce
Copy link
Member

lebauce commented Jan 2, 2019

run vagrant-tests

@EmilienM
Copy link
Contributor Author

EmilienM commented Jan 11, 2019

@safchain @lebauce I'll need help on that one, for the logs. This time it fails on actual skydive tests.

Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.042Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.043Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.043Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.044Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.045Z DEBUG config/rbac.go:54 (*logger).Print analyzer1: Request: admin, topology, read ---> true
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.045Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.046Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.060Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.061Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.073Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.073Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found
Jan 11 16:04:21 analyzer1 skydive[10438]: 2019-01-11T16:04:21.075Z ERROR enhancers/topology_manager.go:109 (*TopologyManager).createEdge analyzer1: Source or Destination node not found

@safchain
Copy link
Collaborator

rerun skydive-vagrant-tests

@EmilienM
Copy link
Contributor Author

Feb 20 10:05:29 agent1 skydive[8299]: 2019-02-20T10:05:29.566Z ERROR lldp/lldp.go:329 (*Probe).handleNode agent1: Failed to add multicast address: invalid argument

is it expected?

@safchain
Copy link
Collaborator

@EmilienM sorry for the delay, the CI machines were off due to office relocation. For the errors we are working on fixing them.

@lebauce
Copy link
Member

lebauce commented Feb 20, 2019

run skydive-vagrant-tests

6 similar comments
@lebauce
Copy link
Member

lebauce commented Feb 20, 2019

run skydive-vagrant-tests

@lebauce
Copy link
Member

lebauce commented Feb 20, 2019

run skydive-vagrant-tests

@safchain
Copy link
Collaborator

run skydive-vagrant-tests

@safchain
Copy link
Collaborator

run skydive-vagrant-tests

@safchain
Copy link
Collaborator

run skydive-vagrant-tests

@safchain
Copy link
Collaborator

run skydive-vagrant-tests

@safchain
Copy link
Collaborator

rerun skydive-vagrant-tests

@safchain
Copy link
Collaborator

run skydive-vagrant-tests

5 similar comments
@safchain
Copy link
Collaborator

run skydive-vagrant-tests

@safchain
Copy link
Collaborator

run skydive-vagrant-tests

@safchain
Copy link
Collaborator

run skydive-vagrant-tests

@safchain
Copy link
Collaborator

run skydive-vagrant-tests

@lebauce
Copy link
Member

lebauce commented Mar 19, 2019

run skydive-vagrant-tests

EmilienM and others added 9 commits March 20, 2019 08:49
Background:
libpod aka Podman is library for running OCI-based containers in Pods.
It is likely going to replace Docker in newer versions of RHEL systems,
which means Docker won't be supported in the future.

The CLI is supposed to work like it did with Docker (with some changes);
so this patch is pretty basic. It adds skydive_container_cli variable
(default to docker for backward compatibiility) and replace the
hardcoded "docker" commands by using this variable instead.

Some adjustments were made:
- podman doesn't need docker socket access.
- podman doesn't support --restart natively, we need a systemd service.
- podman doesn't require to have docker started.

Future iterations will be made to support proper SystemD/Podman
integration like it was done in TripleO for other containers:
http://my1.fr/blog/openstack-containerization-with-podman-part-2-operations/

Closes #1517
Signed-off-by: Emilien Macchi <emilien@redhat.com>
@masco masco merged commit d000b7b into skydive-project:master Mar 20, 2019
@EmilienM EmilienM deleted the issue/1517 branch October 6, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants