Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Forms plugin not installing on Build 420 #74

Closed
markandmedia opened this issue Aug 15, 2017 · 11 comments
Closed

Magic Forms plugin not installing on Build 420 #74

markandmedia opened this issue Aug 15, 2017 · 11 comments
Labels

Comments

@markandmedia
Copy link

Probably already a known issue, during a test drive with Build 420 (Laravel 5.5 update), the Magic Forms plugin does not install.

I love your plugin! This is of course no problem at the moment

@skydiver skydiver added the bug label Aug 28, 2017
@ghost
Copy link

ghost commented Aug 29, 2017

Personnaly, I could install magic form on 420, but it thow a fatal error on all pages (don't know if it's better) ^^

Here is an attached screenshot of the error it throw

@skydiver
Copy link
Owner

Will be fixed in the next version

@skydiver
Copy link
Owner

skydiver commented Aug 29, 2017

@markandmedia or @Alex360hd

The fix is on the master branch, can anyone test if it's works on 420?

Thanks.-

@markandmedia
Copy link
Author

I very well might be doing something wrong,.

Downloaded the plugin from GitHub and uploaded this version in the test-site. There is nog error when I load the page with the component, but after a submit it throws the following sql error:

"SQLSTATE[42S02]: Base table or view not found: 1146 Table 'frisselstein_db.martin_forms_records' doesn't exist (SQL: insert into martin_forms_records (ip, form_data, group, updated_at, created_at) values (86.91.61.161, {"Naam":"Test naam","Straatnaam":"volkelseweg","Nummer":"8","Postcode":"5405NA","Woonplaats":"Uden","email":"markvandenelzen@gmail.com","Bericht":"test"}, Contact formulier, 2017-08-29 13:36:13, 2017-08-29 13:36:13))" on line 647 of /var/www/vhosts/markand.nl/frisselstein.markand.nl/vendor/laravel/framework/src/Illuminate/Database/Connection.php

@skydiver
Copy link
Owner

@markandmedia have you logged in and logged out in the backend?

(when logged in the magic forms tables are created)

@markandmedia
Copy link
Author

I tried that but during login in it throws the following error:

screenshot

@ghost
Copy link

ghost commented Aug 30, 2017

Personnally I could update october to 420 and it works with magic form. You have to update magic form before october CMS.

Don't forget to launch the following command line :

php artisan october:up

to force magic form to update table while stile on 419, then, upgrade october to 420.

@skydiver
Copy link
Owner

The update was pushed to "edge channel" ... you can update directly from october backend

@markandmedia
Copy link
Author

Finally had some time to do a new test. I first installed a clean copy of octoberCMS, installed this plugin and after those steps did the Edge update (build 421).

The errors are now gone! There is one error left after sending the form:

"Address in mailbox given [] does not comply with RFC 2822, 3.6.2." on line 354 of /vendor/swiftmailer/swiftmailer/lib/classes/Swift/Mime/Headers/MailboxHeader.php"

Plugin settings as written after configuring the plugin from the octoberCMS:

[genericForm]
group = "Contact formulier"
rules[Naam] = "required"
rules[Email] = "required|email"
messages_success = "Bedankt voor het invullen, we hebben het formulier met succes ontvangen!"
messages_errors = "Er is helaas iet smis gegaan bij het versturen van het formulier"
mail_enabled = 1
mail_subject = "Contact formulier"
mail_recipients[] = "mark@markandmedia.nl"

As a solution removing [] works (I did not try adding a second email address, it might work with multiple addresses out of the box):

mail_recipients = "mark@markandmedia.nl"

A small thing, probably easily fixed in a future update!

Once again, I'm truly happy with this plugin you created!! There is no way I will be using a Edge version of octoberCMS in a production setting.

@skydiver
Copy link
Owner

@markandmedia the error "Address in mailbox given [] does not comply with" was fixed ...

Also, the update was pushed to stable channel, so everyone will receive the fix.

@ghost
Copy link

ghost commented Sep 11, 2017

Thank you @skydiver I was having this error after install in 1.0.422 , now it is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants