RibbonView changes x/y position when being recreated #4
Comments
|
HI, @ubuntudroid, |
|
Related to #3 |
3 tasks
skydoves
added a commit
that referenced
this issue
Aug 21, 2020
…ng-position-even-if-layout-didnt-change #4 Fix RibbonView changing position even if layout didn't change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please complete the following information:
Describe the Bug:
When using RibbonView in e.g. a RecyclerView, clicking on an item in the RecyclerView, and then returning to the RecyclerView after a few times the position of the ribbon will change.
The likely reason for this is a missing check in
onLayout(changed: Boolean, ...)whether the layout actually did change. Only then the rotation code should be applied which also changes x/y values of the View.I'll provide a PR with a fix.
Expected Behavior:
Postition of the ribbon always stays stable.
The text was updated successfully, but these errors were encountered: