Fatal Exception: java.lang.IllegalStateException

[Canato]

Please complete the following information:

• Library Version 1.2.9
• Affected Device(s) Samsung, Xiaomi, HUAWEI, OPPO OS 8,9,10

The Bug:

I'm using only showAlignTop method, but in some cases this crash is popping on my Firebase Crashlytics.

The specified child already has a parent. You must call removeView() on the child's parent first.

Fatal Exception: java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.
       at android.view.ViewGroup.addViewInner(ViewGroup.java:5106)
       at android.view.ViewGroup.addView(ViewGroup.java:4935)
       at android.view.ViewGroup.addView(ViewGroup.java:4907)
       at android.widget.PopupWindow.createBackgroundView(PopupWindow.java:1530)
       at android.widget.PopupWindow.preparePopup(PopupWindow.java:1492)
       at android.widget.PopupWindow.showAsDropDown(PopupWindow.java:1417)
       at android.widget.PopupWindow.showAsDropDown(PopupWindow.java:1380)
       at com.skydoves.balloon.Balloon$showAlignTop$$inlined$show$1.run(Balloon.java:1774)
       at android.os.Handler.handleCallback(Handler.java:883)
       at android.os.Handler.dispatchMessage(Handler.java:100)
       at android.os.Looper.loop(Looper.java:214)
       at android.app.ActivityThread.main(ActivityThread.java:7403)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)

Possible solution:

Was not able to full reproduce yet, but maybe we can find the right part of the library and to some parent check, like

if(tv.getParent() != null) {
    ((ViewGroup)tv.getParent()).removeView(tv); // <- fix
}
layout.addView(tv);

[skydoves]

Hi, @Canato!
Do you use the setLayout method for customizing the balloon popup?

[Canato]

Hi, @Canato!
Do you use the setLayout method for customising the balloon popup?

Thanks for the fats answer. I didn't

This is my creation code

private fun newBalloon(text: String, clickListener: (() -> Unit)? = null): Balloon? {
        latestBalloon?.dismiss()
        latestBalloon = null
        val listener = if (clickListener == null) {
            { }
        } else {
            { clickListener() }
        }

        return context?.let { ctx ->
            createBalloon(ctx) {
                setText(text)
                setOnBalloonClickListener(OnBalloonClickListener { listener() })

                setArrowSize(12)
                setDismissWhenClicked(true)
                setDismissWhenTouchOutside(false)
                setArrowOrientation(ArrowOrientation.BOTTOM)
                setArrowConstraints(ArrowConstraints.ALIGN_ANCHOR)
                setArrowPosition(0.5f)
                setTextSize(18f)
                setCornerRadius(24f)
                setPadding(12)
                setElevation(8)
                setMarginBottom(12)
                isRtlSupport(resources.getBoolean(R.bool.is_right_to_left))
                setTextTypeface(Typeface.BOLD)
                ResourcesCompat.getFont(ctx, R.font.spezia_bold)?.let { setTextTypeface(it) }
                setTextColor(
                    ContextCompat.getColor(
                        ctx,
                        R.color.muzmatch_3_0_light_type_headers_color
                    )
                )
                setTextGravity(Gravity.CENTER)
                setTextIsHtml(true)
                setBackgroundColor(ContextCompat.getColor(ctx, R.color.muzmatch_white_color))
                setBalloonAnimation(BalloonAnimation.FADE)
                setLifecycleOwner(lifecycleOwner)
            }
        }
    }

In my case I have 3 tooltips in the screen, some time I need to hide all (dismiss) and show again later, anchor again on the same view.

[Canato]

Making some more search, when we dismiss we remove the parent only on the chain of calls:
fun dismiss() -> this.bodyWindow.dismiss() -> onTransitionEnd -> dismissImmediate(decorView, contentHolder, contentView) -> mWindowManager.removeViewImmediate(decorView);

this could means that we can try to setup the parent again because isShowing flag is already false

A small concurrent issue.

Would be sensible to create a showOnLastAnchor() method to use after dismiss() ?

[skydoves]

Thanks for your trace!
This issue will be resolved in the next release.

In the PopupWindow, the contentView should be added on the background view of the PopupWindow internally and that was the reason for creating the concurrency issue.

So I just removed the unused setBackgroundDrawable. (d7d1b1d)

if (mBackground != null) {
            mBackgroundView = createBackgroundView(mContentView);
            mBackgroundView.setBackground(mBackground);
        } else {
            mBackgroundView = mContentView;
        }

[skydoves]

@Canato
Released a new version 1.3.1!
Please check about this issue :)

[Canato]

Thanks @skydoves putting for test soon, working as expecte will close this

[Canato]

Look like this is fixed @skydoves found other issue, but my code I believe. Thanks, let you know anything

[skydoves]

@Canato
Thanks for your issue and supports! 👍

[Canato]

@skydoves over the weekend, pop up a similar issue in another place

Fatal Exception: java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.
       at android.view.ViewGroup.addViewInner(ViewGroup.java:5958)
       at android.view.ViewGroup.addView(ViewGroup.java:5777)
       at android.view.ViewGroup.addView(ViewGroup.java:5734)
       at android.widget.PopupWindow.createDecorView(PopupWindow.java:1595)
       at android.widget.PopupWindow.preparePopup(PopupWindow.java:1535)
       at android.widget.PopupWindow.showAsDropDown(PopupWindow.java:1449)
       at android.widget.PopupWindow.showAsDropDown(PopupWindow.java:1412)
       at com.skydoves.balloon.Balloon$showAlignTop$$inlined$show$1.run(Balloon.java:2092)
       at android.os.Handler.handleCallback(Handler.java:883)
       at android.os.Handler.dispatchMessage(Handler.java:100)
       at android.os.Looper.loop(Looper.java:237)
       at android.app.ActivityThread.main(ActivityThread.java:7948)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1075)

But instead of createBackgroundView now is createDecorView

Want me to open a new issue?

[skydoves]

@Canato
Hmm.. I think the balloon should be shown when the contentView has no parent view for preventing the concurrency issue.
I will test and add some more conditions on the show method.
Thanks for your report :)

[skydoves]

A new alpha version 1.3.2-alpha01 has been released.
The showing conditions have been modified based on your issue.

[Canato]

100% safe @skydoves thanks for the fast responsive on this. muzmatch working like an charm

[skydoves]

@Canato
Perfect! Thanks for your contribution :)