Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder.setOverlayPaddingResource() results in a wrong overlay padding #212

Closed
vitkhudenko opened this issue Jul 26, 2021 · 3 comments
Closed

Builder.setOverlayPaddingResource() results in a wrong overlay padding #212

vitkhudenko opened this issue Jul 26, 2021 · 3 comments
Assignees
@skydoves
Labels
bug Something isn't working Released Released already on the latest version.

Comments

@vitkhudenko
Copy link
Contributor

Environment:

  • Library Version: 1.3.6-SNAPSHOT
  • My Device: Google Nexus 5X (Android 8.1)

Describe the Bug:

Assuming there is a dimen declaration:
<dimen name="overlay_padding">2dp</dimen>

Using the Builder.setOverlayPaddingResource(R.dimen.overlay_padding) results in a much bigger (in times) overlay padding. How much bigger most likely depends on the device's screen pixel density.

Expected Behavior:

Actual requested size is applied.
@skydoves skydoves self-assigned this Jul 27, 2021
@skydoves skydoves added bug Something isn't working Release Next This feature will be released on next version labels Jul 27, 2021
@skydoves skydoves mentioned this issue Jul 27, 2021
Merged
@vitkhudenko
Copy link
Contributor Author

@skydoves, can I access the fixed version via any of the snapshot releases?

@skydoves
Copy link
Owner

Hi @vitkhudenko,
you can access the 1.3.6-212-SNAPSHOT version. Thanks!

skydoves added a commit that referenced this issue Jul 28, 2021
@skydoves
Merge pull request #215 from skydoves/fix/overlay-padding
38ae711 
Fix overlay padding units (#212)
@skydoves
Copy link
Owner

1.3.6 stable has been released!
Thanks for your issue.

@skydoves skydoves added Released Released already on the latest version. and removed Release Next This feature will be released on next version labels Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skydoves skydoves

Labels
bug Something isn't working Released Released already on the latest version.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitkhudenko @skydoves