Fix min max ratio inconsistency in getMeasuredTextWidth #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoePaul
commented
Aug 9, 2021
| @@ -1226,7 +1226,7 @@ class Balloon( | |||
| val spaces = rootView.paddingLeft + rootView.paddingRight + if (builder.iconDrawable != null) { | |||
| builder.iconWidth + builder.iconSpace | |||
| } else 0 + builder.marginRight + builder.marginLeft + (builder.arrowSize * 2) | |||
| val maxTextWidth = displayWidth - spaces | |||
| val maxTextWidth = builder.maxWidth - spaces | |||
There was a problem hiding this comment.
I found a bug with maxTextWidth in getMeasuredTextWidth that when we had longer texts we would get this behavior
when the expected behavior should be like the following
skydoves
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again, I found an inconsistency in the code that I wrote in #214. In getMeasuredTextWidth I used coerceIn instead of coerceAtMost which is more consistent with how the other cases is written. The subtraction of spaces outside of the coerceIn-function gave some unwanted behavior where the dialog would be smaller than intended