Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectified Issue #298 #303

Merged
merged 6 commits into from
Jan 8, 2022
Merged

Rectified Issue #298 #303

merged 6 commits into from
Jan 8, 2022

Conversation

itsnitish22
Copy link
Contributor

Types of changes

Rectified the issue of background colour inconsistency on the tap of any item in the balloon of action item on the Top Nav Bar.
Issue #298

Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @itsnitish22,
Thanks for making this RP! I left some comments for some changes which are not related to this issue.

build.gradle Outdated Show resolved Hide resolved
balloon/build.gradle Outdated Show resolved Hide resolved
@itsnitish22
Copy link
Contributor Author

Seems like it was done by Android Studio.
I have done the required changes now.

Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Here's one more tweak.

build.gradle Outdated Show resolved Hide resolved
@itsnitish22
Copy link
Contributor Author

Hope it works now 😆

@skydoves skydoves self-requested a review January 8, 2022 15:05
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skydoves skydoves merged commit a5d896b into skydoves:main Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants