Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor views constructor and inititialization #10

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Refactor views constructor and inititialization #10

merged 2 commits into from
Jan 20, 2020

Conversation

eagskunst
Copy link
Contributor

Guidelines

I changed the constructors and initialization of ElasticViews. Instead of writing multiple constructors, I use the @jvmoverloads annotation, default values and the init block to check what functions to call.

Types of changes

What types of changes does your code introduce?

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@skydoves skydoves self-requested a review January 20, 2020 15:02
skydoves
skydoves approved these changes Jan 20, 2020
View reviewed changes
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@skydoves skydoves merged commit 3f4cf6f into skydoves:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eagskunst @skydoves