Support multiplatform #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martmists <martmists@gmail.com>
skydoves
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Hey @Martmists-GH,
This is a very amazing contribution. All looks good to me!
I'm just wondering if we can support iOS as well. Can't we also place all the orbital codes inside commomMain and target Apple/iOS?
|
I just realized all those codes are already located in the |
skydoves
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
(Partially) fixes #23
Code has been updated to Compose 1.5.3 and gradle has been set up to support Kotlin Multiplatform (currently only Android+JVM, but JS should be possible too)
I'm unfamiliar with the groovy syntax and how to set up publishing, so I had to disable it to get gradle to sync.
Types of changes
What types of changes does your code introduce?