Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Delete] remove SavedStateHandle parameter in MainViewModel.kt #42

Merged
merged 1 commit into from
Sep 5, 2021
Merged

[Delete] remove SavedStateHandle parameter in MainViewModel.kt #42

merged 1 commit into from
Sep 5, 2021

Conversation

eoqkrskfk94
Copy link
Contributor

@eoqkrskfk94 eoqkrskfk94 commented Sep 5, 2021 •
edited
Loading

Guidelines

Types of changes

parameter SavedStateHandle of MainViewModel class was never used so i deleted it

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

skydoves
skydoves approved these changes Sep 5, 2021
View reviewed changes
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Thanks for your contribution!

@skydoves skydoves merged commit 2d37c93 into skydoves:main Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eoqkrskfk94 @skydoves