Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus state #97

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Conversation

sebastienrouif
Copy link
Contributor

馃幆 Goal

When launching a menu, it currently does get focus which makes it impossible to access when using keyboard navigation

馃洜 Implementation details

I simply set the window to be focusable

鉁嶏笍 Explain examples

Example is no navigable through keyboard when using .isFocusable

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Then dump binary APIs of this library that is public in sense of Kotlin visibilities and ensures that the public binary API wasn't changed in a way that makes this change binary incompatible.

./gradlew apiDump

Please correct any failures before requesting a review.

Code reviews

All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult GitHub Help for more information on using pull requests.

@sebastienrouif
Copy link
Contributor Author

resolves #81

Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@skydoves skydoves merged commit 0306538 into skydoves:main Dec 3, 2022
@sebastienrouif
Copy link
Contributor Author

Thanks @skydoves , could you release a snapshot or full version ?

@sebastienrouif sebastienrouif deleted the fix/fix_focus_state branch December 5, 2022 09:40
@sebastienrouif
Copy link
Contributor Author

@skydoves I can't find the snapshot version on maven, is the snapshot release working? otherwise would you mind starting a release ?

@skydoves
Copy link
Owner

skydoves commented Dec 7, 2022

Hey @sebastienrouif, sorry for the late response. I will release the next stable version this week and let you know soon!
And thank you so much for your contribution :)

@skydoves
Copy link
Owner

skydoves commented Dec 7, 2022

Btw you can import the snapshot version below:

implementation "com.github.skydoves:powermenu:2.2.2-SNAPSHOT"

Also, please make sure you added the snapshot repository below on your maven settings.

maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' }

@sebastienrouif
Copy link
Contributor Author

I was missing the second part

@sebastienrouif
Copy link
Contributor Author

sorry to bother you, I was hopping to include a stable version of the library this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants