-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix focus state #97
Fix focus state #97
Conversation
resolves #81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Thanks @skydoves , could you release a snapshot or full version ? |
@skydoves I can't find the snapshot version on maven, is the snapshot release working? otherwise would you mind starting a release ? |
Hey @sebastienrouif, sorry for the late response. I will release the next stable version this week and let you know soon! |
Btw you can import the snapshot version below:
Also, please make sure you added the snapshot repository below on your maven settings. maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' } |
I was missing the second part |
sorry to bother you, I was hopping to include a stable version of the library this week |
馃幆 Goal
When launching a menu, it currently does get focus which makes it impossible to access when using keyboard navigation
馃洜 Implementation details
I simply set the window to be focusable
鉁嶏笍 Explain examples
Example is no navigable through keyboard when using
.isFocusable
Preparing a pull request for review
Ensure your change is properly formatted by running:
Then dump binary APIs of this library that is public in sense of Kotlin visibilities and ensures that the public binary API wasn't changed in a way that makes this change binary incompatible.
Please correct any failures before requesting a review.
Code reviews
All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult GitHub Help for more information on using pull requests.