Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to support difference between spinner and popup #39

Closed
MJ1998 opened this issue Sep 15, 2020 · 3 comments
Closed

Feature to support difference between spinner and popup #39

MJ1998 opened this issue Sep 15, 2020 · 3 comments
Assignees
Labels
released released already the last version

Comments

@MJ1998
Copy link

MJ1998 commented Sep 15, 2020

Is your feature request related to a problem?
Yes.

A clear and concise description of what the problem is.
Basically I need to set a border color only to the spinner. So after adding the border background, the popup is so close that it hides the bottom border.

Describe the solution you'd like:
Feature to support difference between spinner and popup

A clear and concise description of what you want to happen.
An attribute that supports this difference.

Describe alternatives you've considered:
Tried appending PowerSpinner xml to Relative layout ad setting background of the relative layout only. Same problem.

A clear description of any alternative solutions you've considered.
<RelativeLayout
lh..
lw..
background="@drawable/border"
..>
<PowerSpinner
..
/>

@skydoves skydoves self-assigned this Oct 2, 2020
@skydoves skydoves added the released released already the last version label Oct 8, 2020
@skydoves
Copy link
Owner

skydoves commented Oct 8, 2020

Hi @MJ1998, sorry for the late reply.
It is released in a new version 1.1.4.

We can resolve this issue using a yOff attribute on show() or showOrDismiss() function.

powerSpinnerView.setOnClickListener {
  powerSpinnerView.showOrDismiss(xOff = 0, yOff = 30) // 30 px offset from the spinnerView.
}

@skydoves skydoves closed this as completed Oct 8, 2020
@jakoss
Copy link

jakoss commented Oct 9, 2020

I have the same issue as OP, the provided solution does not work well:
image

As you can see - bottom border disappeared anyway, and popup is strangely low

@skydoves skydoves reopened this Oct 11, 2020
@skydoves
Copy link
Owner

@jakoss
Give the border for all edges with small yOff.

The result:
KakaoTalk_20201129_133837371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released released already the last version
Projects
None yet
Development

No branches or pull requests

3 participants