Fixed Text clipping issue during transition animations. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skydoves
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Looks good to me! Thank you for your contribution @hemantj99 馃憤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃幆 Goal
The changes in this pull request address an issue where text were being cut off during transition animations from HomeScreen to DetailScreen.
Current Behavior
VID_20240415225524.mp4
After Fix Behavior
1000058203.mp4
馃洜 Implementation details
This Pull Request addresses a text clipping issue during transition animations by rearranging the modifier property for the Text composable within the PokemonCard component. By moving the padding configuration after the pokedexSharedElement modifier, we ensure proper padding application without affecting the shared transition behavior. These changes helps resolving text clipping problems while maintaining code readability and adherence to best practices.
鉁嶏笍 Explain examples
Explain examples with code for this updates.
Preparing a pull request for review
Ensure your change is properly formatted by running:
$ ./gradlew spotlessApplyPlease correct any failures before requesting a review.