Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constellation boundary bug #547

Closed
mgarraha opened this issue Feb 6, 2021 · 1 comment
Closed

Constellation boundary bug #547

mgarraha opened this issue Feb 6, 2021 · 1 comment

Comments

@mgarraha
Copy link
Contributor

mgarraha commented Feb 6, 2021

extend() displaces RA boundaries by 2s in a few cases, e.g. '18.1750' becomes 18.1755...
I'm testing a fix.

python-skyfield/builders/build_constellations.py

Line 155 in dd4ec5b

s = s[:-2] + 30 * s[-2:-1] + s[-1:]

mgarraha added a commit to mgarraha/python-skyfield that referenced this issue Feb 6, 2021
@mgarraha
Read constellation boundaries more accurately (skyfielders#547)
b77fc3d
@mgarraha mgarraha mentioned this issue Feb 6, 2021
Merged
@brandon-rhodes
Copy link
Member

Your rounding solution is clever and works better (obviously) than mine! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandon-rhodes @mgarraha