Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressbar glitching #271

Closed
drskrzyk opened this issue May 7, 2021 · 7 comments
Closed

Addressbar glitching #271

drskrzyk opened this issue May 7, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@drskrzyk
Copy link

drskrzyk commented May 7, 2021

I have a clean build on ubuntu studio 20.04, on release branch (1.4.0) built with the following uptions: cmake ../lagrange -DCMAKE_BUILD_TYPE=RELEASE -DCMAKE_INSTALL_PREFIX=$HOME/.local/share -DENABLE_MPG123=YES -DENABLE_WINDOWPOS_FIX=YES

image

When switching between tabs occasionally the address bar will show "snow" like artifacts as shown above.

I am going to try building with SW render to rule out some bad interaction with the native render.

@drskrzyk
Copy link
Author

drskrzyk commented May 7, 2021

Compiling with -DENABLE_X11_SWRENDER=YES enabled via cmake corrected this issue.

Please let me know if you'd like further investigation/testing/information from me!

@skyjake
Copy link
Owner

skyjake commented May 7, 2021

I haven’t seen this myself, but it’s definitely related to buffering the input field contents on a texture for faster drawing. Looks like the texture wasn’t cleared properly.

I’ll check if I can spot anything that could cause this.

@skyjake
Copy link
Owner

skyjake commented May 7, 2021

Could you check which version of SDL you’re building with?

@drskrzyk
Copy link
Author

drskrzyk commented May 7, 2021

Sure!
libsdl2-dev/focal,now 2.0.10+dfsg1-3 amd64

@skyjake skyjake added the bug Something isn't working label May 9, 2021
@skyjake
Copy link
Owner

skyjake commented May 9, 2021

I'll try compiling with SDL 2.0.10 myself and see what kind of workaround is needed. I believe more recent versions of SDL do not have this problem.

@skyjake skyjake self-assigned this May 9, 2021
@skyjake
Copy link
Owner

skyjake commented May 11, 2021

So far I've been unable to reproduce this glitch.

@drskrzyk
Copy link
Author

I'm not horribly concerned as I was able to work around it with the software rendering. The workstation that exhibits this behavior is an Intel NUC with integrated intel video. The appimage doesn't act like this, so my build environment could be suspect too.

I'll close this up and dig around further on my end. Thank you for looking into it.

skyjake added a commit that referenced this issue Jun 14, 2021
It is possible that calling `SDL_RenderClear` was not performing the expected clearing of the TextBuf texture due to the wrong blend mode being in effect.

IssueID #271
skyjake added a commit that referenced this issue Jun 15, 2021
It is possible that calling `SDL_RenderClear` was not performing the expected clearing of the TextBuf texture due to the wrong blend mode being in effect.

IssueID #271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants