Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a warning system #7

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

alexpvpmindustry
Copy link
Contributor

warns the user until the warning threshold.
if warn number reaches the warning threshold, kicks the player to alex hub xD.
feel free to change the URL, or to change it to just plain kick.

@skykatik
Copy link
Owner

skykatik commented Jan 1, 2021

ActivityInfo not saved in settings.bin. It for game session and warnings may be reset when player disconnected

for(Player player : Groups.player){
if (player==null) continue;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont understand what you mean.
do u mean the Player player in Groups.player will always be not null?

Copy link
Contributor Author

@alexpvpmindustry alexpvpmindustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActivityInfo not saved in settings.bin. It for game session and warnings may be reset when player disconnected

this is ok i think. not necessary to save more stuff into settings.bin.
if the player re-logins, we could consider the player as non-afk (since the player will probably need to click on a few buttons).
if the player uses an auto-login macro or bot to reset the afk warning, then he could have easily just moved his ship to avoid the afk kick in the first place.

for(Player player : Groups.player){
if (player==null) continue;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont understand what you mean.
do u mean the Player player in Groups.player will always be not null?

@alexpvpmindustry alexpvpmindustry marked this pull request as draft January 2, 2021 05:51
@YoMamaLlama1
Copy link

The warning does not warn in some servers .-. . Pretty sure in some of the pvp servers

@skykatik skykatik mentioned this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants