Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize cluster names / make names with underscores be able to run on GCP #139

Closed
concretevitamin opened this issue Jan 6, 2022 · 1 comment · Fixed by #156
Closed

Comments

@concretevitamin
Copy link
Collaborator

concretevitamin commented Jan 6, 2022

multi_echo.py was using the cluster name multi_echo. When forcing it on GCP, it failed with

googleapiclient.errors.HttpError: <HttpError 400 when requesting https://compute.googleapis.com/compute/v1/projects/intercloud-320520/zones/us-west1-a/instances?alt=json returned "Invalid value for field 'resource.name': 'ray-multi_echo-head-480dea0e'. Must be a match of regex '(?:a-z?)'". Details: "[{'message': "Invalid value for field 'resource.name': 'ray-multi_echo-head-480dea0e'. Must be a match of regex '(?:a-z?)'", 'domain': 'global', 'reason': 'invalid'}]">

Replacing the name with multi-echo worked. It must be regex (?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)

Need to design a solution (force replace _ with -? some other approach?).

@gmittal
Copy link
Collaborator

gmittal commented Jan 8, 2022

Related: sky gpunode 42 will fail because 42 is not a string, but then its also not removable from the status table because of the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants