-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAML support for sky.Storage #96
Comments
@romilbhardwaj @concretevitamin Since |
Good point - we could take the kubernetes approach and define storage objects as a list of storages each with a unique id (e.g. see
If want to stay true to our python API, then we can define storage objects inline in storage_mounts:
What do you guys think? |
How should we express "get_or_copy_to_s3()"? A direct attempt:
|
As we discussed today, here's the schema:
|
Evolving from our discussion today, here's the final schema I propose:
I agree, this adds an additional line but allows us to have a well defined and consistent schema. My opinion on this is influenced by k8s, so please feel free to push back if you feel this is too much boilerplate code to write.
|
This has landed by @michaelzhiluo #121. |
Sky storage (#63) will also require YAML support so Storage objects can be defined as a part of the YAML schema. Maybe something like:
The text was updated successfully, but these errors were encountered: