-
-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added static casts of size_t
container sizes
#3
Conversation
Previously `size_t` values returned by the internal containers were implicitely converted to the ECS `size_type` which results in compiler warnings.
At the end of the day, the type of the entities rules on the size and the size type. I added |
I was a little bit confused why |
I pushed on master a few changes that should clean things up. Can you give me a feedback, please? |
Oh, I'm sorry, appveyor is having problems for I didn't set master as default branch. I'm going to fix it, not a problem. Give me a couple of minutes. |
The problem is the usage of the alias template
in the pack expansion context of the initializer:
Replacing it with the full class name:
fixes the error. |
Push upstream and added |
Cool. Yes, everything seems fine now. |
Thank you very much. I'm closing this issue and considering it solved. |
Previously
size_t
values returned by the internal containers were implicitly converted to the ECSsize_type
which results in compiler warnings about possible loss of accuracy (ifsize_type
<size_t
). If you want to make the user aware of this issue, I would rather add an assert in thecreate()
method or something like this.