Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default ctor of meta::factory should be public. #7

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

gamecentric
Copy link

Fixes a compilation issue in C++20, where the factory{} initializer used by the meta::reflect helper function (and possibly elsewher) invokes the default costructor instead of using aggregate initialization as it does in C++17 and earlier.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 111

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 110: 0.0%
Covered Lines: 765
Relevant Lines: 765

💛 - Coveralls

@skypjack skypjack self-assigned this Sep 3, 2019
@skypjack skypjack added the bug Something isn't working label Sep 3, 2019
@skypjack
Copy link
Owner

skypjack commented Sep 3, 2019

Indeed. Thank you. 👍

@skypjack skypjack merged commit cfba127 into skypjack:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants