Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined uint32_t error on 2.12.1 under GCC 13 #288

Closed
wants to merge 1 commit into from

Conversation

fcelda
Copy link
Contributor

@fcelda fcelda commented May 27, 2023

uvw 2.12.1 currently doesn't compile with GCC 13 (Fedora 38) because type_info.hpp doesn't have correct include for standard integers.

/home/fcelda/devel/uvw/src/uvw/type_info.hpp:17:37: error: ‘uint32_t’ in namespace ‘std’ does not name a type; did you mean ‘wint_t’?
   17 | [[nodiscard]] static constexpr std::uint32_t fnv1a(const char *curr) noexcept {
      |                                     ^~~~~~~~
      |                                     wint_t

Standard integers are defined in cstdint. The removed header cstdef seems unused.

@fcelda
Copy link
Contributor Author

fcelda commented May 27, 2023

Oh. It looks like this has been fixed already. 👍 Thanks.

@fcelda fcelda closed this May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant