Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed DECam config file #151

Merged
merged 13 commits into from
Nov 24, 2023
Merged

fixed DECam config file #151

merged 13 commits into from
Nov 24, 2023

Conversation

igorandreoni
Copy link
Contributor

I made these fixes:

  • the available filters are ugrizy, not only r
  • horizon key was repeated
  • slew rate and overheads were incorrect

mcoughlin
mcoughlin requested changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leave it as r, otherwise good. We would need to build in more capabilities to have multiple filter, magnitude and exposure time keys.

gwemopt/data/config/DECam.config Outdated
@@ -1,4 +1,4 @@
filt r
filt ugrizy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use one filter to just scale limiting magnitudes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mcoughlin
Copy link
Collaborator

@igorandreoni Looks like the test output files need to be updated with this. https://github.com/skyportal/gwemopt/blob/main/gwemopt/tests/test_schedule.py#L62
@robertdstein had left an example here.

@mcoughlin mcoughlin self-requested a review November 24, 2023 22:52
mcoughlin
mcoughlin approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging. Tests confuse me a bit.

@mcoughlin mcoughlin merged commit 8309151 into skyportal:main Nov 24, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoughlin mcoughlin mcoughlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igorandreoni @mcoughlin