Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of ULTRASAT Configuration Files #153

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Conversation

weizmannk
Copy link
Contributor

This pull request introduces a series of updates to the gwemopt project. The updates include the inclusion of ULTRASAT configuration files, the addition of "params" to the lightcurve module to allow direct capture of filters specified by the user via the command line instead of using a fixed default filters, the introduction of arguments for location and observability, and the implementation of observability thresholds.

@weizmannk
Copy link
Contributor Author

Hi! @mcoughlin
Here is the pull request. Now, everything should be okay as it's working fine. However, the warning is still present (you know we already discuss about it and you were waitting for @Theodlz . Another issue I've encountered is that I cannot use the --doMovie argument because ffmpeg, as referenced here https://github.com/skyportal/gwemopt/blob/main/gwemopt/plotting/movie.py#L21, is not functioning, and I'm unsure how to fix it. I was running it on LHO, so I didn't have sudo access to install this package. Could you please explain what exactly ffmpeg is and how I can install it on a server without sudo privileges?

@mcoughlin
Copy link
Collaborator

@weizmannk Can you please run your pre-commit and fix the linting on these files?

@weizmannk
Copy link
Contributor Author

@mcoughlin It's done but I still see that Some checks were not successful .

@mcoughlin mcoughlin self-requested a review January 9, 2024 15:11
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoughlin mcoughlin merged commit 05c4a9c into skyportal:main Jan 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants