-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classifications colors #4017
Classifications colors #4017
Conversation
@celiune Can you please add me as a collaborator on your fork? |
@KodeurFou @Adiman007 @celiune Thanks for this, it is closer: I think instead of hardcoding these 4 types: confirmed, rejected, not_confirmed, and obs, cleaner and more generic would be: classifications: {'kilonova': '#03c04a', 'supernova': '#ff0000'} and then you just need to check for colors in the chip loop. Also please just modify config.yaml.defaults, we do not commit config.yaml to the repo. |
classifications: {'kilonova': '#03c04a', 'supernova': '#ff0000'}, only two classifications are needed ?
|
@Adiman007 My suggestion is just showing a few examples that show up in the demo data, I.e. variable, is fine. Folks can modify the config on deploy to fill out the colors and types they want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KodeurFou @Adiman007 @celiune.
Hi @mcoughlin, with @KodeurFou and @Adiman007 we've made the changes asked in the previous pull request Colors in Classifications. We've opened a new pull request as @KodeurFou's skyportal is broken for the moment and no change could be made.
Hoping that it's good now!