Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classifications colors #4017

Merged
merged 10 commits into from
Mar 9, 2023
Merged

Conversation

celiune
Copy link
Contributor

@celiune celiune commented Mar 7, 2023

Hi @mcoughlin, with @KodeurFou and @Adiman007 we've made the changes asked in the previous pull request Colors in Classifications. We've opened a new pull request as @KodeurFou's skyportal is broken for the moment and no change could be made.
Hoping that it's good now!

@mcoughlin
Copy link
Contributor

@celiune Can you please add me as a collaborator on your fork?

@mcoughlin
Copy link
Contributor

@KodeurFou @Adiman007 @celiune Thanks for this, it is closer:

I think instead of hardcoding these 4 types: confirmed, rejected, not_confirmed, and obs, cleaner and more generic would be:

classifications: {'kilonova': '#03c04a', 'supernova': '#ff0000'}

and then you just need to check for colors in the chip loop. Also please just modify config.yaml.defaults, we do not commit config.yaml to the repo.

@Adiman007
Copy link
Contributor

classifications: {'kilonova': '#03c04a', 'supernova': '#ff0000'}, only two classifications are needed ?

@KodeurFou @Adiman007 @celiune Thanks for this, it is closer:

I think instead of hardcoding these 4 types: confirmed, rejected, not_confirmed, and obs, cleaner and more generic would be:

classifications: {'kilonova': '#03c04a', 'supernova': '#ff0000'}

and then you just need to check for colors in the chip loop. Also please just modify config.yaml.defaults, we do not commit config.yaml to the repo.

@mcoughlin
Copy link
Contributor

@Adiman007 My suggestion is just showing a few examples that show up in the demo data, I.e. variable, is fine. Folks can modify the config on deploy to fill out the colors and types they want.

@github-actions github-actions bot added the config-change Pull requests that change the config file label Mar 7, 2023
Copy link
Contributor

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcoughlin mcoughlin merged commit 3f68789 into skyportal:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-change Pull requests that change the config file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants