pipeline: generic interface for pipeline items #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +32,12 @@ def test_load_skypy_yaml(): | |||
| load_skypy_yaml(filename) | |||
|
|
|||
|
|
|||
| def test_empty_ref(): | |||
| filename = get_pkg_data_filename('data/test_empty_ref.yml') | |||
| with pytest.raises(ValueError, match='empty reference'): | |||
There was a problem hiding this comment.
Looking at the yml file for this test, is this still an empty reference? Or a broken one?
There was a problem hiding this comment.
My thinking here was that at the config (i.e. YAML) level we can only catch empty strings being passed when the !ref tag is used without argument. We could also let it go to the pipeline level and check there, but then we lose the information about where the error happened.
Which now makes me think that the next iteration of this should be adding 'file', 'line' and 'column' information to Item on construction so that the pipeline can do all of the checking and give great error messages.
rrjbca
requested changes
Nov 27, 2020
rrjbca
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a generic base class
Itemfor pipeline items, and two concretisationsRef(reference to another variable) andCall(function call). The pipeline items have three methods:inferto infer additional properties from context (e.g. thecosmologyargument inCall),dependto return the dependencies of the item, andevaluateto return the computed value of the item.This removes special cases from the
Pipelineclass and makes it easily extendable to other types of items.